feat(linkTools.Vertices): add vertexAdding interactiveLinkNode option #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current solution with the
linkTools.Verticesand its extra path overlay has several disadvantages. For example, it was not possible to move labels and create vertices at the same time (because an invisible path was rendered above the link and the labels).This PR allows you to choose an existing node from the link view to serve as an interactive hit area for creating vertices.
Docs
https://docs.jointjs.com/api/linkTools/#vertices
vertexAdding
Can the user add new vertices (by clicking a segment of the link)?
falsetrue{}VertexAddingOptionsVertexAddingOptions
interactiveLinkNode: string;selectorof an existing link node, e.g."wrapper". When the node is interacted with, a vertex is created.The default is
true.Implements #2688.
Solves: #2370